Breadcrumbs Refactor #4858
Merged
Breadcrumbs Refactor #4858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
nileshgulia1
requested changes
Jun 19, 2023
…into breadcrumbs-refactor
…into breadcrumbs-refactor
| import { getBreadcrumbs } from '@plone/volto/actions'; | ||
| import { getBaseUrl, hasApiExpander } from '@plone/volto/helpers'; | ||
|
|
||
| import { useBreadcrumbs } from '@plone/volto/hooks/breadcrumbs/useBreadcrumbs'; |
There was a problem hiding this comment.
You can export this in https://github.com/plone/volto/blob/master/src/hooks/index.js
and then directly import from @plone/volto/hooks
nileshgulia1
approved these changes
Jun 24, 2023
…into breadcrumbs-refactor
nileshgulia1
approved these changes
Jun 26, 2023
…into breadcrumbs-refactor
93 tasks
JeffersonBledsoe
approved these changes
Jul 8, 2023
There was a problem hiding this comment.
@Tishasoumya-02 Looks good, let's get this merged!
@nileshgulia1 If you're happy, give Victor a ping and LGTM.
sneridagh
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4460